Verifying the git repo

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

Verifying the git repo

Ivan Habunek
Hi all,

The new git repository is set up and located at:
https://git-wip-us.apache.org/repos/asf/logging-log4php.git

Quoting:
"It is the responsibility of each project to review the Git history in
their new repository before it is made the official repository. In the
event that a project has to revert to SVN due to a bad Git clone, it
is the project's responsibility to reapply writes made to Git back to
SVN. It is in the project's best interest to make sure that the
history is correct before starting to use it as an official
repository."
-- from https://git-wip-us.apache.org/docs/switching-to-git.html

I will try to verify everything is good, but I would appreciate extra
sets of eyes on this one! So clone and compare with svn if you have
the time, and report any issues here. Thanks!

There is one known issue, since we renamed our tags to be compatible
with Composer, they seem to appear twice for each released version.
E.g. both old style: "apache-log4php-2.3.0" and new: "2.3.0". This
should not present a problem, we'll just delete the old tag style
after migration is final.

Regards,
Ivan
Reply | Threaded
Open this post in threaded view
|

Re: Verifying the git repo

Ivan Habunek
Heads up,

If no problems are found by Monday (T+3) then I will notify infra to
continue with the migration process.

Please take a little time to review the repo and reply to the list if
you have any objections or remarks.

Regards,
Ivan

On 30 November 2012 08:09, Ivan Habunek <[hidden email]> wrote:

> Hi all,
>
> The new git repository is set up and located at:
> https://git-wip-us.apache.org/repos/asf/logging-log4php.git
>
> Quoting:
> "It is the responsibility of each project to review the Git history in
> their new repository before it is made the official repository. In the
> event that a project has to revert to SVN due to a bad Git clone, it
> is the project's responsibility to reapply writes made to Git back to
> SVN. It is in the project's best interest to make sure that the
> history is correct before starting to use it as an official
> repository."
> -- from https://git-wip-us.apache.org/docs/switching-to-git.html
>
> I will try to verify everything is good, but I would appreciate extra
> sets of eyes on this one! So clone and compare with svn if you have
> the time, and report any issues here. Thanks!
>
> There is one known issue, since we renamed our tags to be compatible
> with Composer, they seem to appear twice for each released version.
> E.g. both old style: "apache-log4php-2.3.0" and new: "2.3.0". This
> should not present a problem, we'll just delete the old tag style
> after migration is final.
>
> Regards,
> Ivan
Reply | Threaded
Open this post in threaded view
|

Re: Verifying the git repo

Vladimír Gorej
+1

I did not find any problems with the repo, except already known problem with the duplicate tags. I reviewed some of the history commits with 'git gui' tool and everything seemed fine.
Maybe we should have a look at this: https://help.github.com/articles/dealing-with-line-endings#platform-all, if commiters/contributors develop on various platforms.


On Fri, Nov 30, 2012 at 4:38 PM, Ivan Habunek <[hidden email]> wrote:
Heads up,

If no problems are found by Monday (T+3) then I will notify infra to
continue with the migration process.

Please take a little time to review the repo and reply to the list if
you have any objections or remarks.

Regards,
Ivan

On 30 November 2012 08:09, Ivan Habunek <[hidden email]> wrote:
> Hi all,
>
> The new git repository is set up and located at:
> https://git-wip-us.apache.org/repos/asf/logging-log4php.git
>
> Quoting:
> "It is the responsibility of each project to review the Git history in
> their new repository before it is made the official repository. In the
> event that a project has to revert to SVN due to a bad Git clone, it
> is the project's responsibility to reapply writes made to Git back to
> SVN. It is in the project's best interest to make sure that the
> history is correct before starting to use it as an official
> repository."
> -- from https://git-wip-us.apache.org/docs/switching-to-git.html
>
> I will try to verify everything is good, but I would appreciate extra
> sets of eyes on this one! So clone and compare with svn if you have
> the time, and report any issues here. Thanks!
>
> There is one known issue, since we renamed our tags to be compatible
> with Composer, they seem to appear twice for each released version.
> E.g. both old style: "apache-log4php-2.3.0" and new: "2.3.0". This
> should not present a problem, we'll just delete the old tag style
> after migration is final.
>
> Regards,
> Ivan



--
Vladimír Gorej | CodeScale s.r.o.
email: [hidden email]
tel: +420 777 861 279, +421 948 023 011
web: http://www.codescale.net

Reply | Threaded
Open this post in threaded view
|

Re: Verifying the git repo

Ivan Habunek
On 30 November 2012 17:07, Vladimír Gorej <[hidden email]> wrote:
> I did not find any problems with the repo, except already known problem with
> the duplicate tags. I reviewed some of the history commits with 'git gui'
> tool and everything seemed fine.

Yeah, i did the same using tortoise-git, and all seems well.

> Maybe we should have a look at this:
> https://help.github.com/articles/dealing-with-line-endings#platform-all, if
> commiters/contributors develop on various platforms.

Well, the plan was to start using PSR-2 coding standard, and it says
that all files should use unix-style line breaks (LF) regardless of
the platform.

So the simplest solution is to put the following line in .gitattributes:
* text eol=lf

That way all line breaks will be converted to LF.

Regards,
Ivan
Reply | Threaded
Open this post in threaded view
|

Re: Verifying the git repo

Vladimír Gorej
Regarding git branching model, I read these two howtos:



This document is pretty much thought out, and I guess it really covers the development/release processes of log4php. I would use it as a reference. Since now, I was
using lightweight tags, but document recommends using annotated tags with -a option. For this kind of project that log4php is, annotated tags are more suitable.
So +1 from me, for this model.



Even though, the first document doesn't cover too much, there is really interesting passage about rebasing multiple commits.




On Sun, Dec 2, 2012 at 4:58 PM, Ivan Habunek <[hidden email]> wrote:
On 30 November 2012 17:07, Vladimír Gorej <[hidden email]> wrote:
> I did not find any problems with the repo, except already known problem with
> the duplicate tags. I reviewed some of the history commits with 'git gui'
> tool and everything seemed fine.

Yeah, i did the same using tortoise-git, and all seems well.

> Maybe we should have a look at this:
> https://help.github.com/articles/dealing-with-line-endings#platform-all, if
> commiters/contributors develop on various platforms.

Well, the plan was to start using PSR-2 coding standard, and it says
that all files should use unix-style line breaks (LF) regardless of
the platform.

So the simplest solution is to put the following line in .gitattributes:
* text eol=lf

That way all line breaks will be converted to LF.

Regards,
Ivan



--
Vladimír Gorej | CodeScale s.r.o.
email: [hidden email]
tel: +420 777 861 279, +421 948 023 011
web: http://www.codescale.net