[VOTE] Release log4net 2.0.6 based on RC1

classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

[VOTE] Release log4net 2.0.6 based on RC1

Stefan Bodewig
Hi all

log4net 2.0.6 RC1 is available for review here:
  https://dist.apache.org/repos/dist/dev/logging/log4net
  (revision 17495)

Details of changes since 1.2.15 are in the release notes:
  http://stefan.samaflost.de/staging/log4net-2.0.6/release/release-notes.html

I have tested this with Mono and several .NET frameworks using NAnt.

The tag is here:
  https://svn.apache.org/repos/asf/logging/log4net/tags/2.0.6RC1
  (revision 1775236)

Site:
  http://stefan.samaflost.de/staging/log4net-2.0.6/

RAT Report:
  http://stefan.samaflost.de/staging/log4net-2.0.6/rat-report.html

Nuget Package:
  https://www.myget.org/feed/log4net-test/package/nuget/log4net

Votes, please.  This vote will close in 72 hours, 1000 GMT 24-Dec 2016

[ ] +1 Release these artifacts
[ ] +0 OK, but...
[ ] -0 OK, but really should fix...
[ ] -1 I oppose this release because...

Thanks!

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release log4net 2.0.6 based on RC1

Stefan Bodewig
Making my own vote explicit

On 2016-12-20, Stefan Bodewig wrote:

> Votes, please.  This vote will close in 72 hours, 1000 GMT 24-Dec 2016

> [X] +1 Release these artifacts
> [ ] +0 OK, but...
> [ ] -0 OK, but really should fix...
> [ ] -1 I oppose this release because...

+1

Stefan
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release log4net 2.0.6 based on RC1

Ralph Goers
I suggest you include the PMC in your vote thread.

Ralph

> On Dec 22, 2016, at 7:58 AM, Stefan Bodewig <[hidden email]> wrote:
>
> Making my own vote explicit
>
> On 2016-12-20, Stefan Bodewig wrote:
>
>> Votes, please.  This vote will close in 72 hours, 1000 GMT 24-Dec 2016
>
>> [X] +1 Release these artifacts
>> [ ] +0 OK, but...
>> [ ] -0 OK, but really should fix...
>> [ ] -1 I oppose this release because...
>
> +1
>
> Stefan
>


Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release log4net 2.0.6 based on RC1

Gary Gregory-4
In reply to this post by Stefan Bodewig
Running build.cmd succeeds. ASC, MD5, SHA1, SHA256 OK. If you are going to provide SHA1 or SHA256, you can do away with MD5 IMO.

-1 based on the RAT check failures:
18 Unknown Licenses

*******************************

Unapproved licenses:

  bin/net/2.0/debug/log4net.xml
  bin/net/2.0/release/log4net.xml
  bin/net/3.5/debug/log4net.xml
  bin/net/3.5/release/log4net.xml
  bin/net/4.0/debug/log4net.xml
  bin/net/4.0/release/log4net.xml
  bin/net/4.5/debug/log4net.xml
  bin/net/4.5/release/log4net.xml
  bin/net-cp/3.5/debug/log4net.xml
  bin/net-cp/3.5/release/log4net.xml
  bin/net-cp/4.0/debug/log4net.xml
  bin/net-cp/4.0/release/log4net.xml
  log4net.snk.readme
  netstandard/global.json
  netstandard/log4net/project.json
  netstandard/log4net.tests/project.json
  src/GeneratedAssemblyInfo.cs
  tests/lib/prerequisites.txt

It would help to have a BUILDING.txt file to guide reviewers.



Gary

On Tue, Dec 20, 2016 at 2:07 AM, Stefan Bodewig <[hidden email]> wrote:
Hi all

log4net 2.0.6 RC1 is available for review here:
  https://dist.apache.org/repos/dist/dev/logging/log4net
  (revision 17495)

Details of changes since 1.2.15 are in the release notes:
  http://stefan.samaflost.de/staging/log4net-2.0.6/release/release-notes.html

I have tested this with Mono and several .NET frameworks using NAnt.

The tag is here:
  https://svn.apache.org/repos/asf/logging/log4net/tags/2.0.6RC1
  (revision 1775236)

Site:
  http://stefan.samaflost.de/staging/log4net-2.0.6/

RAT Report:
  http://stefan.samaflost.de/staging/log4net-2.0.6/rat-report.html

Nuget Package:
  https://www.myget.org/feed/log4net-test/package/nuget/log4net

Votes, please.  This vote will close in 72 hours, 1000 GMT 24-Dec 2016

[ ] +1 Release these artifacts
[ ] +0 OK, but...
[ ] -0 OK, but really should fix...
[ ] -1 I oppose this release because...

Thanks!




--
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release log4net 2.0.6 based on RC1

Stefan Bodewig
Many thanks for reviewing

On 2016-12-22, Gary Gregory wrote:

> Running build.cmd succeeds. ASC, MD5, SHA1, SHA256 OK. If you are going to
> provide SHA1 or SHA256, you can do away with MD5 IMO.

> -1 based on the RAT check failures:
> 18 Unknown Licenses

most of them are generated, namely

>   bin/net/2.0/debug/log4net.xml
>   bin/net/2.0/release/log4net.xml
>   bin/net/3.5/debug/log4net.xml
>   bin/net/3.5/release/log4net.xml
>   bin/net/4.0/debug/log4net.xml
>   bin/net/4.0/release/log4net.xml
>   bin/net/4.5/debug/log4net.xml
>   bin/net/4.5/release/log4net.xml
>   bin/net-cp/3.5/debug/log4net.xml
>   bin/net-cp/3.5/release/log4net.xml
>   bin/net-cp/4.0/debug/log4net.xml
>   bin/net-cp/4.0/release/log4net.xml
>   src/GeneratedAssemblyInfo.cs

the next files are JSON files and you can't have comments in JSON

>   netstandard/global.json
>   netstandard/log4net/project.json
>   netstandard/log4net.tests/project.json

which leaves the remaining files

>   log4net.snk.readme
>   tests/lib/prerequisites.txt

which are readmes.

See also
http://stefan.samaflost.de/staging/log4net-2.0.6/rat-report.html and
https://github.com/apache/log4net/blob/trunk/pom.xml#L136

> It would help to have a BUILDING.txt file to guide reviewers.

http://stefan.samaflost.de/staging/log4net-2.0.6/release/building.html

Cheers

        Stefan
Reply | Threaded
Open this post in threaded view
|

[RESULT] Release log4net 2.0.6 based on RC1

Stefan Bodewig
In reply to this post by Stefan Bodewig
The vote for Apache log4net 2.0.6 has passed with three binding +1s by
Domink Psenner, Remko Popma and myself and one -1 by Gary Greggory.

I'll now proceed with publishing the artifacts and will send out the
release announcement once the mirrors have had time to catch up.

Many thanks to those who took the time to review the release.

Stefan